modify find_duplicates_sharedhits #393
Closed
leonardogiannini wants to merge 1 commit intotrackreco:develfrom
Closed
modify find_duplicates_sharedhits #393leonardogiannini wants to merge 1 commit intotrackreco:develfrom
leonardogiannini wants to merge 1 commit intotrackreco:develfrom
Conversation
…n the hits/ no nested trk-trk loops
Collaborator
|
Closing, as superseded by cms-sw/cmssw#37122. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR modifies find_duplicates_sharedhits used in pixelless and tobtec to fdollow a logic similar to cmssw
this allows to avoid nested track-track loops
the timing is reduced by a factor from ~2 to 4, while the physics is not changed i.e. same number of output tracks
new vs old time for the function (10 evts)
speed up plot (10 evts)
